Skip to content

Conversation

@AA-Turner
Copy link
Contributor

@AA-Turner AA-Turner commented May 21, 2025

@AA-Turner AA-Turner force-pushed the multi-phase/lapack_lite branch 2 times, most recently from 26301e9 to 9cde821 Compare May 22, 2025 02:57
@AA-Turner AA-Turner marked this pull request as draft May 24, 2025 06:22
@AA-Turner AA-Turner force-pushed the multi-phase/lapack_lite branch from 9cde821 to d53f13f Compare May 28, 2025 11:21
@AA-Turner AA-Turner marked this pull request as ready for review May 28, 2025 12:28
@AA-Turner
Copy link
Contributor Author

AA-Turner commented May 28, 2025

Test failure seems unrelated: FAILED numpy/linalg/tests/test_linalg.py::TestQR::test_stacked_inputs[float32-outer_size2-size1] - RuntimeWarning: invalid value encountered in matmul. I don't have access to macOS to reproduce, though, sorry.

cc @seberg

@seberg
Copy link
Member

seberg commented May 28, 2025

Looks right to me, yes, the error comes up occasionally, some weird blas thing probably.
Refusing multiple inits is correct, although one may hope that the module is maybe not hard to convert.
(not actually sure, while certainly possible the ufuncs may need work.)

@seberg seberg changed the title GH-29021: Convert lapack_lite to multi-phase init (PEP 489) MAINT: Convert lapack_lite to multi-phase init (PEP 489) May 28, 2025
@seberg seberg merged commit 0145d7c into numpy:main May 28, 2025
73 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants