Skip to content

Conversation

@jorenham
Copy link
Member

@jorenham jorenham added 09 - Backport-Candidate PRs tagged should be backported 41 - Static typing labels Apr 17, 2025
@jorenham
Copy link
Member Author

@charris would it be possible to only backport the first commit (8a2ae20)? The changes in ma/core.pyi build upon #28677, which isn't backported but doing so probably won't cause any issues although @seberg probably wouldn't like that, so we should be careful not to tag him here...

@jorenham
Copy link
Member Author

cc @MarcoGorelli

@charris
Copy link
Member

charris commented Apr 17, 2025

Not sure why we shouldn't backport #28677.

@charris charris merged commit 101621c into numpy:main Apr 17, 2025
74 checks passed
@charris
Copy link
Member

charris commented Apr 17, 2025

Thanks Joren.

@jorenham jorenham deleted the typing/partition-fixes branch April 17, 2025 19:05
@charris
Copy link
Member

charris commented Apr 18, 2025

I decided not to backport #28677, there are a lot of changes in main that have not been backported, and 2.3 isn't that far off.

See #28758. It is failing the typing tests.

@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants