Repository navigation
BLD: fix meson_version warning - #28693
Merged
Merged
Conversation
Member
|
Hmm, there will be a meson update in the near future, maybe we should wait on that. @rgommers Thoughts? |
rgommers
approved these changes
Apr 12, 2025
rgommers
left a comment
rgommers
left a comment
Member
There was a problem hiding this comment.
This is perfectly fine. It doesn't matter too much in practice, since this version check can't fail as long as we're using our vendored meson. But it's more accurate and does avoid the warning, so in it goes.
Thanks Lucas & Chuck.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes gh-26223.
It looks like gh-26464 didn't deal with the warning in the linked issue because
project.meson_versionwasn't updated.Version taken from https://github.com/numpy/meson/blob/0d93515fb826440d19707eee47fd92655fe2f166/mesonbuild/coredata.py#L75.
cc @charris