TYP: Type MaskedArray.take and np.ma.take
#28680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 tasks
jorenham
reviewed
Apr 10, 2025
Member
jorenham
left a comment
jorenham
left a comment
There was a problem hiding this comment.
This looks good. I left some suggestions that could make this even better.
jorenham
approved these changes
Apr 10, 2025
Member
|
there are some merge conflicts |
jorenham
reviewed
Apr 10, 2025
numpy/ma/core.pyi
Outdated
Comment on lines
681
to
688
| @overload | ||
| def take( | ||
| self, | ||
| indices: _IntLike_co, | ||
| axis: SupportsIndex | None = None, | ||
| out: None = None, | ||
| mode: _ModeKind = 'raise', | ||
| ) -> Any: ... |
Member
There was a problem hiding this comment.
The overload above always gets matched, so unless I'm missing something, this one can be removed.
Suggested change
| @overload | |
| def take( | |
| self, | |
| indices: _IntLike_co, | |
| axis: SupportsIndex | None = None, | |
| out: None = None, | |
| mode: _ModeKind = 'raise', | |
| ) -> Any: ... |
Member
Author
There was a problem hiding this comment.
ah, thanks! I was under the impression that some masked arrays could be of dtypes that might not be possible to match against MaskedArray[_SCT], but I should have asked
have removed 👍
numpy/ma/core.pyi
Outdated
Comment on lines
697
to
704
| @overload | ||
| def take( | ||
| self, | ||
| indices: _ArrayLikeInt_co, | ||
| axis: SupportsIndex | None = None, | ||
| out: None = None, | ||
| mode: _ModeKind = 'raise', | ||
| ) -> _MaskedArray[Any]: ... |
Member
There was a problem hiding this comment.
Same story here
Suggested change
| @overload | |
| def take( | |
| self, | |
| indices: _ArrayLikeInt_co, | |
| axis: SupportsIndex | None = None, | |
| out: None = None, | |
| mode: _ModeKind = 'raise', | |
| ) -> _MaskedArray[Any]: ... |
jorenham
approved these changes
Apr 11, 2025
Member
|
Thanks, Marco |
MaanasArora
pushed a commit
to MaanasArora/numpy
that referenced
this pull request
Apr 11, 2025
* TYP: Type ``MaskedArray.take`` and ``np.ma.take`` * broaden `a` type * it gets broader * 🎨 * remove redundant overloads * reduce diff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.