Skip to content

Conversation

@MarcoGorelli
Copy link
Member

No description provided.

@jorenham jorenham self-requested a review April 10, 2025 11:17
@MarcoGorelli MarcoGorelli marked this pull request as ready for review April 10, 2025 12:54
Copy link
Member

@jorenham jorenham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! I was only able find a single nit to pick, which required using my electron microscope. It's a quantum nit, so given the Heisenberg uncertainty principle, it's also fine by me if you want to ignore it and mark it as resolved.

@jorenham jorenham merged commit 75a2a3a into numpy:main Apr 10, 2025
74 checks passed
@jorenham
Copy link
Member

Thanks Marco

MaanasArora pushed a commit to MaanasArora/numpy that referenced this pull request Apr 11, 2025
@charris charris added 09 - Backport-Candidate PRs tagged should be backported and removed 09 - Backport-Candidate PRs tagged should be backported labels Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants