Skip to content

TYP: Type ma.MaskedArray.max and ma.MaskedArray.ptp #28623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jorenham merged 4 commits into from
Apr 2, 2025
Merged

TYP: Type ma.MaskedArray.max and ma.MaskedArray.ptp #28623

jorenham merged 4 commits into from
Apr 2, 2025

Conversation

@MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Apr 2, 2025

Easy follow-up to #28616

Will figure out some more of these

@MarcoGorelli MarcoGorelli marked this pull request as ready for review April 2, 2025 09:16
@jorenham jorenham self-requested a review April 2, 2025 10:37
jorenham
jorenham reviewed Apr 2, 2025
View reviewed changes
@jorenham jorenham mentioned this pull request Apr 2, 2025
Open
52 tasks
@jorenham jorenham added the component: numpy.ma masked arrays label Apr 2, 2025
@jorenham jorenham merged commit e1ba721 into numpy:main Apr 2, 2025
71 of 74 checks passed
@jorenham
Copy link
Member

jorenham commented Apr 2, 2025

Thanks Marco

@MarcoGorelli MarcoGorelli mentioned this pull request Apr 3, 2025
Merged
MaanasArora pushed a commit to MaanasArora/numpy that referenced this pull request Apr 11, 2025
@MarcoGorelli @MaanasArora
TYP: Type ma.MaskedArray.max and ma.MaskedArray.ptp (numpy#28623
7ab9c98 
)

* TYP: Add type annotations for MaskedArray.max and MaskedArray.ptp

* add some fail cases for good measure

* set `ptp` `keepdims` default to `False`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorenham jorenham jorenham left review comments

Assignees

No one assigned

Labels

41 - Static typing component: numpy.ma masked arrays

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MarcoGorelli @jorenham