TYP: Type numpy.ma.min
#28593
Merged
TYP: Type numpy.ma.min
#28593
+89
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
thanks for your review! i've:
not sure what you're asking me to do about |
…lt for when it is explicitly specified
jorenham
approved these changes
Mar 28, 2025
Member
jorenham
left a comment
jorenham
left a comment
There was a problem hiding this comment.
I un-dotted some "i"'s, but it's good to merge now, as far as I'm concerned :)
Member
Author
|
thanks for your help, much appreciated 🙏 |
Closed
Member
Right back at ya! Can't say the same about CI though 🤔 |
Member
|
Thanks @MarcoGorelli 👌🏻 |
jorenham
reviewed
Mar 31, 2025
52 tasks
MaanasArora
pushed a commit
to MaanasArora/numpy
that referenced
this pull request
Apr 11, 2025
* TYP: Type numpy.ma.min * order imports, type defaults, include _NoValueType * add extra overload with `out` being passed positionally, remove default for when it is explicitly specified * set default for fill_value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the existing PR (#26624) may have gone stale, hope it's OK to open another one