BUG: Include Python-including headers first#28172
Merged
charris merged 1 commit intonumpy:mainfrom Jan 17, 2025
Merged
Conversation
BUG: Include python-including headers first in npstd.hpp BUG: Include Python-including headers first in fast_loop_macros.h BUG: Include Python-including headers first in npy_hashtable.cpp BUG: Import Python.h first in dispatching.cpp BUG: Include Python.h first in _pocketfft_umath.cpp
Member
|
Thanks @DWesl . I think clang-format would have fixed some of those, but maybe not all. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while trying to get NumPy to compile on the Cygwin test release of Python 3.12