MAINT: Avoid a redundant copy on a[...] = b#28163
Merged
charris merged 1 commit intonumpy:mainfrom Jan 16, 2025
Merged
Conversation
a[...] = ba[...] = b
Member
|
Thanks Mateusz. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28070
In the example presented in #28070 there's an unnecessary copy made by calling
__array__withcopy=True:I think we can switch from "always copy" to "copy if needed" for the input shape&dtype discovery in the
PyArray_CopyObjectfunction.I want to stress that the
srctodestcopy is done anyway (AFAIU indexed assignment can't return a view) asPyArray_CopyObjectcallsPyArray_AssignArray(dest, src, ...)which iterates over elements and copies them todest.