Skip to content

DOC: Fix sphinx markup in source/reference/random/extending.rst - #28101

Merged
mattip merged 1 commit into
numpy:mainfrom
WarrenWeckesser:doc-fix-extending-cffi
Jan 5, 2025
Merged

mattip merged 1 commit into
numpy:mainfrom
WarrenWeckesser:doc-fix-extending-cffi

Conversation

@WarrenWeckesser

Copy link
Copy Markdown
Member

Change :start-after: dlopen to :start-at: dlopen so the line containing the call of ffi.dlopen() is included.

Change ':start-after: dlopen' to ':start-at: dlopen' so the line
containing the call of 'ffi.dlopen()' is included.

[skip actions] [skip azp] [skip cirrus]
@WarrenWeckesser

Copy link
Copy Markdown
Member Author

The corrected output can be seen at CFFI, where the line

lib = ffi.dlopen(np.random._generator.__file__)

is now included at the start of the second block of code.

@mattip
mattip merged commit 2eccb5e into numpy:main Jan 5, 2025
@mattip

mattip commented Jan 5, 2025

Copy link
Copy Markdown
Member

Thanks @WarrenWeckesser

@WarrenWeckesser
WarrenWeckesser deleted the doc-fix-extending-cffi branch January 5, 2025 11:26
ArvidJB added a commit to ArvidJB/numpy that referenced this pull request Jan 8, 2025
Update the `np.strings.slice` docstrings to follow convention
and correctly split between argument type and documentation.

Also update the `slice` release note to follow convention for
new functions.

Lastly, fix the gcc version upgrade PR reference from numpy#28101
to numpy#28102.
ArvidJB added a commit to ArvidJB/numpy that referenced this pull request Jan 8, 2025
Update the `np.strings.slice` docstrings to follow convention
and correctly split between argument type and documentation.

Also update the `slice` release note to follow convention for
new functions.

Lastly, fix the gcc version upgrade PR reference from numpy#28101
to numpy#28102.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants