Skip to content

ENH: Re-enable VSX from build targets for sin/cos #27627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
seiko2plus merged 2 commits into from
Oct 30, 2024
Merged

ENH: Re-enable VSX from build targets for sin/cos #27627

seiko2plus merged 2 commits into from
Oct 30, 2024
+1 −0

Conversation

@r-devulap
Copy link
Member

@r-devulap r-devulap commented Oct 23, 2024

This reverts commit e7e6574.

@r-devulap r-devulap added component: SIMD Issues in SIMD (fast instruction sets) code or machinery HWY features related to google Highway labels Oct 23, 2024
@r-devulap r-devulap mentioned this pull request Oct 23, 2024
Merged
2 tasks
@r-devulap r-devulap requested a review from seiko2plus October 23, 2024 15:53
@r-devulap
Copy link
Member Author

r-devulap commented Oct 23, 2024

Interesting, the seg faults are gone. Now we are seeing tests failing with accuracy problems and FP exceptions:

numpy/_core/tests/test_umath_accuracy.py:84: AssertionError
=========================== short test summary info ============================
FAILED numpy/_core/tests/test_umath.py::TestSpecialFloats::test_sincos_values[f] - AssertionError: 
FAILED numpy/_core/tests/test_umath.py::TestSpecialFloats::test_sincos_errors[inf-f-sin] - AssertionError: FloatingPointError not raised by sin
FAILED numpy/_core/tests/test_umath.py::TestSpecialFloats::test_sincos_errors[inf-f-cos] - AssertionError: FloatingPointError not raised by cos
FAILED numpy/_core/tests/test_umath.py::TestSpecialFloats::test_sincos_errors[-inf-f-sin] - AssertionError: FloatingPointError not raised by sin
FAILED numpy/_core/tests/test_umath.py::TestSpecialFloats::test_sincos_errors[-inf-f-cos] - AssertionError: FloatingPointError not raised by cos
FAILED numpy/_core/tests/test_umath.py::TestAVXFloat32Transcendental::test_sincos_float32 - AssertionError: Arrays are not almost equal up to 2 ULP (max difference is ...
FAILED numpy/_core/tests/test_umath.py::TestAVXFloat32Transcendental::test_strided_float32 - AssertionError: Arrays are not equal to 2 ULP (max is 1.05785e+09)
FAILED numpy/_core/tests/test_umath_accuracy.py::TestAccuracy::test_validate_fp16_transcendentals[cos] - AssertionError: Arrays are not almost equal up to 1 ULP (max difference is ...
FAILED numpy/_core/tests/test_umath_accuracy.py::TestAccuracy::test_validate_fp16_transcendentals[sin] - AssertionError: Arrays are not almost equal up to 1 ULP (max difference is ...
= 9 failed, 22213 passed, 1559 skipped, 26186 deselected, 7 xfailed, 2 xpassed in 555.12s (0:09:15) =

@seiko2plus seiko2plus merged commit cbd0e41 into numpy:main Oct 30, 2024
63 of 65 checks passed
@seiko2plus
Copy link
Member

seiko2plus commented Oct 30, 2024

Thank you @r-devulap.

@seiko2plus seiko2plus mentioned this pull request Nov 9, 2024
Merged
seberg pushed a commit that referenced this pull request Nov 22, 2024
@seiko2plus
ENH: Re-enable VXE from build targets for sin/cos (#27665)
be54bff 
For clarification, SIMD optimizations for sine and cosine functions on both ppc64 and z/Architecture (IBM Z) were disabled by gh-25781 to bypass CI tests. This PR aims to re-enable optimizations for z/Architecture after addressing the following runtime errors, while gh-27627 re-enabled ppc64 optimizations.

* Re-enable VXE for sin/cos HWY implementation

---------

Co-authored-by: Sayed Adel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seiko2plus seiko2plus Awaiting requested review from seiko2plus

Assignees

No one assigned

Labels

01 - Enhancement component: SIMD Issues in SIMD (fast instruction sets) code or machinery HWY features related to google Highway

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@r-devulap @seiko2plus