BUILD: satisfy gcc-13 pendantic errors #27564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charris
added
36 - Build
Member
Author
|
CI is passing, BLAS errors are gone |
charris
reviewed
Oct 15, 2024
| if (result != ptr) { | ||
| PyTraceMalloc_Untrack(NPY_TRACE_DOMAIN, (npy_uintp)ptr); | ||
| } | ||
| PyTraceMalloc_Track(NPY_TRACE_DOMAIN, (npy_uintp)result, size); |
Member
There was a problem hiding this comment.
Note that PyTraceMalloc_Track can return an error.
Member
Author
There was a problem hiding this comment.
Oy. It can return 0 for success, -1 for MemoryError, -2 for tracing disabled. Good catch.
Member
|
Thanks Matti. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27548 pragmatically, without diving into whether the compiler is correct or not. The changes should be harmless.