Skip to content

Conversation

@r-devulap
Copy link
Member

Addressing #27492 (comment)

@r-devulap
Copy link
Member Author

crashed and burned, will figure out after the weekend :)

@rgommers
Copy link
Member

@r-devulap note that SciPy has a working Linux CI job with the Intel LLVM compilers - probably easiest to copy that approach and modify. It's not so easy to get the right things installed with caching etc.

@r-devulap
Copy link
Member Author

@r-devulap note that SciPy has a working Linux CI job with the Intel LLVM compilers - probably easiest to copy that approach and modify. It's not so easy to get the right things installed with caching etc.

Thanks for that. I will look it up. The workflow in the PR worked locally for me, so hoping this should be okay.

@r-devulap
Copy link
Member Author

yay, finally passed! @AgilentGCMS, any feedback here? Is there anything specific thing you want covered as part of CI?

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @r-devulap, good to see this green. I think the test selection is wrong though - this just runs a small subset of tests (_linalg/ufunc/umath tests on Intel TGL) like for the SIMD tests, but I'd expect it to run the regular test suite instead. And then the job would be better placed in linux.yml rather than in linux_simd.yml. Is there a reason not to do this?

The build stage looks good. There was one minor issue with warnings for SVML object files, but that's unrelated to this job really so I opened a separate PR to fix that up (gh-27587).

@r-devulap
Copy link
Member Author

Not sure if we really need this, closing for now. Will reopen if we need it at a later stage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants