Repository navigation
TST: Catch possible warnings - #2745
Merged
Merged
Conversation
Contributor
Author
|
Ok, I can see already that the "with" statement can't be used since it doesn't work in Python 2.5.... |
Member
|
Like I said on the list but more explicit: |
Previously the test sometimes fails with the following error:
======================================================================
ERROR: Test a special case for var
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/travis/virtualenv/python3.2/lib/python3.2/site-packages/numpy/ma/tests/test_core.py", line 2731, in test_varstd_specialcases
_ = method(out=mout)
File "/home/travis/virtualenv/python3.2/lib/python3.2/site-packages/numpy/ma/core.py", line 4778, in std
np.power(out, 0.5, out=out, casting='unsafe')
RuntimeWarning: invalid value encountered in power
----------------------------------------------------------------------
Now we catch it, as recommended by the thread:
http://old.nabble.com/Should-abs(-nan-)-be-supported--td34389839.html
Contributor
Author
|
Thanks Ralf. I implemented this manual method and rebased. Let's see if tests pass this time. |
Contributor
Author
|
I forgot to merge this. All tests pass and the PR was reviewed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the commit log for more details. Now all tests should always pass on Travis-CI.