Skip to content

Conversation

@PinkPandaKatie
Copy link
Contributor

Fixes #27405.

@charris charris changed the title BUG: Stub out get_build_msvc_version if distutils.msvccompiler cannot be imported BUG: Stub out get_build_msvc_version if distutils.msvccompiler cannot be imported Sep 16, 2024
@mattip
Copy link
Member

mattip commented Sep 17, 2024

The numpy.distutils module is deprecated.

@ngoldbaum ngoldbaum added the 57 - Close? Issues which may be closable unless discussion continued label Sep 17, 2024
@charris charris merged commit 781e231 into numpy:main Sep 19, 2024
@charris
Copy link
Member

charris commented Sep 19, 2024

Thanks @PinkPandaKatie .

@mattip Started to see failing tests on CI on account of this bug.

@mattip
Copy link
Member

mattip commented Sep 19, 2024

Which CI?

@charris
Copy link
Member

charris commented Sep 19, 2024

Which CI?

macOS x86-64 conda (3.11)

Merging this got rid of one error, one remains. The Python 3.11.10 release may have broken things. I'm thinking of just removing msvccompiler from the api checks. I mean, the failure is on the Mac, and distutils itself will be going away soon enough.

@mattip
Copy link
Member

mattip commented Sep 20, 2024

We don't pin setuptools in the conda runs. See #27429

@charris charris removed the 57 - Close? Issues which may be closable unless discussion continued label Oct 5, 2024
@rgommers rgommers added this to the 2.2.0 release milestone Oct 31, 2024
@rgommers rgommers added the 09 - Backport-Candidate PRs tagged should be backported label Oct 31, 2024
@rgommers
Copy link
Member

I just saw this now. While numpy.disutils is deprecated, we should still accept PRs that fix bugs, especially if they're very easy to review like this one - if someone has a real-world problem and it's annoying enough that they come here to fix it (which seems to be the case here), then let's just apply the fixes.

For context: found this today because it tripped someone up in a conda-forge feedstock. Easier to backport this to the next bug fix release than trying to work around it in conda-forge.

@charris
Copy link
Member

charris commented Oct 31, 2024

@rgommers Already done in 6b9ef48. It wasn't in the changelog because it was part of getting the release preparation PR passing. Should be in the 2.1.2 release.

@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Oct 31, 2024
@rgommers
Copy link
Member

Ah great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: ModuleNotFoundError: No module named 'distutils.msvccompiler' on Linux

5 participants