Repository navigation
Fix setting of fill_value for string columns in Python 3 - #2733
Merged
Merged
Conversation
Member
|
Fix looks OK, two minor points:
|
Contributor
Author
|
@rgommers - do you mean that it should be: or The way I had it was the same as for the other regression tests, and the output with for the |
Member
|
I meant the latter. But if that file has many similar issues, it's fine to leave it as is now. I'll fix it once I get annoyed again by not being able to find some failing test quickly. |
rgommers
pushed a commit
that referenced
this pull request
Nov 21, 2012
Fix setting of fill_value for string columns in Python 3
Member
|
OK, merged. Thanks @astrofrog |
Member
|
@certik any objection to backporting this? |
Contributor
|
No objections. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As first discovered in astropy/astropy#451 by @taldcroft, there is a bug with setting the fill value of a string array in MaskedArray with Python 3.x:
The attached code fixes this.