-
-
Notifications
You must be signed in to change notification settings - Fork 11.9k
CI: pycodestyle → ruff #27300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
CI: pycodestyle → ruff #27300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d228f09 to
a0cedfc
Compare
c06a976 to
db32de3
Compare
This comment was marked as outdated.
This comment was marked as outdated.
a917c81 to
63c51ee
Compare
ed54ac3 to
1a7bb78
Compare
fc84b4b to
dc9b434
Compare
E211 Whitespace before '('
cc92e6e to
56a7137
Compare
Contributor
Author
|
Replacing pycodestyle with ruff is being discussed in #24994. |
E221 Multiple spaces before operator
E222 Multiple spaces after operator
E225 Missing whitespace around operator
E226 Missing whitespace around arithmetic operator
E227 Missing whitespace around bitwise or shift operator
E228 Missing whitespace around modulo operator
E252 Missing whitespace around parameter equals
E261 Insert at least two spaces before an inline comment
E271 Multiple spaces after keyword
E272 Multiple spaces before keyword
E275 Missing whitespace after keyword
E301 Expected 1 blank line between methods
E303 Too many blank lines
E304 Blank lines found after function decorator
E305 Expected 2 blank lines after class or function definition
E306 Expected 1 blank line before a nested definition
E501 Line too long
E714 Test for object identity should be `is not`
E743 Ambiguous function name
Ruff has found 1080 occurrences of this error. Fixing them sounds excessive.
56a7137 to
242dcdc
Compare
Member
|
Well, here goes. Thanks @DimitriPapadopoulos . Would be good to get those linter failures fixed up. |
Contributor
Author
|
Thank you @charris. I will try to fix the linter failures. Curiously, they don't occur when running ruff from directly from the command line. Perhaps a configuration issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24994.
Supsersedes #27308.