Skip to content

Conversation

@DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Aug 27, 2024

Fixes #24994.

Supsersedes #27308.

@DimitriPapadopoulos DimitriPapadopoulos force-pushed the ruff branch 8 times, most recently from d228f09 to a0cedfc Compare August 27, 2024 22:50
@DimitriPapadopoulos DimitriPapadopoulos changed the title CI: pycodestyle → ruff check CI: pycodestyle → ruff Aug 28, 2024
@DimitriPapadopoulos

This comment was marked as outdated.

E211 Whitespace before '('
@DimitriPapadopoulos DimitriPapadopoulos force-pushed the ruff branch 2 times, most recently from cc92e6e to 56a7137 Compare December 16, 2024 08:39
@DimitriPapadopoulos
Copy link
Contributor Author

Replacing pycodestyle with ruff is being discussed in #24994.

E221 Multiple spaces before operator
E222 Multiple spaces after operator
E225 Missing whitespace around operator
E226 Missing whitespace around arithmetic operator
E227 Missing whitespace around bitwise or shift operator
E228 Missing whitespace around modulo operator
E252 Missing whitespace around parameter equals
E261 Insert at least two spaces before an inline comment
E271 Multiple spaces after keyword
E272 Multiple spaces before keyword
E275 Missing whitespace after keyword
E301 Expected 1 blank line between methods
E303 Too many blank lines
E304 Blank lines found after function decorator
E305 Expected 2 blank lines after class or function definition
E306 Expected 1 blank line before a nested definition
E714 Test for object identity should be `is not`
E743 Ambiguous function name
Ruff has found 1080 occurrences of this error. Fixing them sounds excessive.
@charris charris merged commit c31e599 into numpy:main Dec 16, 2024
65 of 66 checks passed
@charris
Copy link
Member

charris commented Dec 16, 2024

Well, here goes. Thanks @DimitriPapadopoulos . Would be good to get those linter failures fixed up.

@DimitriPapadopoulos
Copy link
Contributor Author

Thank you @charris. I will try to fix the linter failures. Curiously, they don't occur when running ruff from directly from the command line. Perhaps a configuration issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Linting Package Replacement: Pycodestyle to Ruff

2 participants