TST: work around flaky test on free-threaded build#26503
Merged
charris merged 1 commit intonumpy:mainfrom May 23, 2024
Merged
Conversation
ngoldbaum
added
the
39 - free-threading
Member
Author
|
I ended up tracing this to the fact that |
Member
|
Let's give it a shot. Thanks Nathan. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The newly added free-threaded CI is seeing intermittent test failures caused by this test. See e.g. this run.
This is a weird bug, from the error message, somehow a RuntimeWarning is getting created, and then during the handling of the warning, pytest doesn't see it. But only sometimes. In my test using
pytest-repeatto repeatedly run this test I see unhandled warnings anywhere from 0% to 20% of the time. It happens more often in an optimized build of numpy than in a debug build (which is why I missed it during local testing).This smells like a bug in either pytest or CPython and I will try to figure out what exactly is happening. For now it looks like
pytest.raisesdoesn't have the same issue.