Skip to content

Conversation

@ngoldbaum
Copy link
Member

@ngoldbaum ngoldbaum commented May 16, 2024

No description provided.

@ngoldbaum ngoldbaum added 05 - Testing component: CI 39 - free-threading PRs and issues related to support for free-threading CPython (a.k.a. no-GIL, PEP 703) labels May 16, 2024
@ngoldbaum ngoldbaum marked this pull request as ready for review May 16, 2024 21:27
@rgommers rgommers self-requested a review May 21, 2024 12:27
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ngoldbaum! This LGTM modulo one typo in the job config.

This all seems to work as advertised; the correct Python is pulled in, the Cython wheel build tag contains cp313t (t for free-threaded), and the NumPy under test picks up the correct Python:

 Program python3 found: YES (/home/runner/venv-3.13/bin/python3.13-nogil)

Feel free to merge after fixing the typo.

free-threaded:
needs: [smoke_test]
runs-on: ubuntu-latest
if: github.even_name != 'push'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: event_name

[skip azp] [skip cirrus] [skip circle]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

05 - Testing 39 - free-threading PRs and issues related to support for free-threading CPython (a.k.a. no-GIL, PEP 703) component: CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants