MNT: migrate PyList_GetItem usages to PyList_GetItemRef #26246
Merged
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
If this sort of migration is fine, I'll start next on migrating usages of |
mhvk
approved these changes
Apr 9, 2024
Contributor
mhvk
left a comment
mhvk
left a comment
There was a problem hiding this comment.
Seems sensible. Doing quick git grep, it seems the total number of cases of any of these is, thankfully, not all that large!
Member
|
Thanks Nathan. |
rgommers
added
39 - free-threading
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEP 703 has some discussion about why this is necessary. In short, in a GIL-less python, it's possible for
itemin all three cases to be garbage collected before thePyTuple_GetItemcall can execute. UsingPyList_GetItemRefensures that can't happen.There's still one more
PyList_GetItemusage in a test, but it's there specifically to test C API usages that create borrowed references, so I left it alone.