MAINT: Remove unnnecessary size argument in StringDType initializer#25856
Merged
charris merged 1 commit intonumpy:mainfrom Feb 20, 2024
Merged
MAINT: Remove unnnecessary size argument in StringDType initializer#25856charris merged 1 commit intonumpy:mainfrom
charris merged 1 commit intonumpy:mainfrom
Conversation
14 tasks
charris
approved these changes
Feb 20, 2024
Member
|
Thanks Nathan. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is one of the followup tasks from #25693.
This argument was needed during stringdtype development so that I could hook into the string manipulation functions from the old
np.charnamespace.Now that
StringDTypeis in numpy we can remove the argument to make the API simpler.