Repository navigation
BUG: handle scalar input in np.char.replace - #25484
Merged
Merged
Conversation
seberg
approved these changes
Dec 24, 2023
seberg
left a comment
seberg
left a comment
Member
There was a problem hiding this comment.
LGTM, scalar return logic is of course in the air (it's not the same as ufuncs), but unchanged here and presumably before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I merged #25171 last night. However, it was never updated to handle scalars properly following #25335, so the test added in that PR started failing as soon as #25171 was merged.
This updates the
replaceimplementation to properly handle scalars following the other chararray functions.ping @lysnikolaou if you happen to see this and want to do it another way, please let me know, I just did this quickly to fix CI.