Closed
Conversation
mtsokol
approved these changes
Dec 18, 2023
Contributor
Author
|
See #25416 for what should be the better alternative, of creating a gufunc for vecdot. |
Member
charris
approved these changes
Dec 18, 2023
Contributor
Author
|
I think #25416 is the proper solution, but want to be sure that at least one gets merged. If it is easier, we can merge this and I will just rebase. But also fine to make this a draft or close it for now. |
Member
|
OK, I made it a draft and we will see how #25416 goes. |
Member
|
Closing this, the ufunc versions seems close to going in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #25155, a new
vecdotfunction was introduced. This fixes two aspectsgufunc.I'm not sure the latter is consistent with the array API, though if it isn't, there likely are problems elsewhere too.