Repository navigation
BLD: make macOS version check for Accelerate NEWLAPACK more robust - #25040
Conversation
Incorporates numpy/meson#6 Closes numpygh-25026 [skip azp] [skip circle]
|
Thanks Ralf. |
|
This doesn't want to backport. Do we need #25008 as well? |
|
Ah fun with git submodules. We don't strictly need gh-25008 and it's a large PR, that's why I didn't mark it for a backport. However, we either need to backport that or we need to create a new branch specific to 1.26.x in our fork of So let's backport both? If you want me to deal with it, just say the word. |
|
The problems with #25008 are likely to be because of the because of the |
|
@rgommers The way to deal with the renames is to download the PR as a patch and edit the files before applying. Unfortunately, you have been happily removing distutils related stuff :) The easy way to fix that is to give up on setup for 1.26, which seems reasonable to me. Or we could just go with a 1.27 ... |
|
I think the moral of that story is "Don't try to support two build systems". We have been there before. |
|
Yes, I think we can drop |
|
For completeness: this fix did get backported to the |
Incorporates numpy/meson#6
Closes gh-25026
[skip azp] [skip circle]