Repository navigation
Conversation
This also fixes a cast for raw scalars, however, it seems unlikely to affect code in practice (much or at all).
Member
Author
|
Oh, I hadn't realized that this was just ancient, and I already redid this later... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a start of a cleanup, removing only the most obvious unused code chunks/paths. The main reasoning for doing this, is that it allows replacing further legacy code paths.
It would also make some experiments such as not converting incoming scalars to an array right away, feasible.
Some such experiments/optimizations are not possible as long as we need full legacy path support.
I would like to go with this because it is a big cleanup and allows further cleanups. It does however mean that one has to rely on numpy 1.26 if you want the "warning" option to get a sense of how much breakage there is or track down a change (and in some additional niche cases the warnings may be off with the final result due to fixes not backported).
(There is also a lot more related code, that is still relevant for niche public API Functions.)