Skip to content

DOC: Update NEP 52 file #24620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ngoldbaum merged 3 commits into from
Sep 18, 2023
Merged

DOC: Update NEP 52 file #24620

ngoldbaum merged 3 commits into from
Sep 18, 2023

Conversation

@mtsokol
Copy link
Member

@mtsokol mtsokol commented Sep 2, 2023

Hi @rgommers,

I started updating NEP 52 file: I removed bullet-points that we agreed to drop from the 2.0 release and added links to relevant issues with discussions.
How detailed would you like this update? Should I link all PRs and list specific changes?

@mtsokol mtsokol self-assigned this Sep 2, 2023
@mtsokol mtsokol requested a review from rgommers September 2, 2023 10:32
rgommers
rgommers reviewed Sep 4, 2023
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mateusz, this looks like a good start.

How detailed would you like this update? Should I link all PRs and list specific changes?

Probably not, that's too much. How about you choose a selection of the key ones, and for the rest note that there's a NumPy 2.0 API Changes label that contains all the relevant PRs?

The other addition that would be useful I think is to comment on things that we considered but eventually rejected as changes for some reason? Most often that's "significant usage, so impact too high", but for example for the busday ones it's because moving them is a lot of work - too much for 4 functions. Perhaps add a new section right above Related Work that is titled API changes considered and rejected?

@mtsokol
Copy link
Member Author

mtsokol commented Sep 11, 2023

Hi @rgommers,
I pushed new changes. I wasn't sure about Resolution entry so I put "NEP 52 Tracking Issue" there. Or do we have an announcement from the mailing list that I should put there?

@rgommers rgommers mentioned this pull request Sep 15, 2023
Merged
@rgommers rgommers added this to the 2.0.0 release milestone Sep 15, 2023
@rgommers
Copy link
Member

rgommers commented Sep 15, 2023

Or do we have an announcement from the mailing list that I should put there?

Yes indeed - see https://numpy.org/neps/nep-0000.html#how-a-nep-becomes-accepted. I just sent that email, so that's the thread to link: https://mail.python.org/archives/list/[email protected]/thread/QLMPFTWA67DXE3JCUQT2RIRLQ44INS4F/

@ngoldbaum
Copy link
Member

ngoldbaum commented Sep 18, 2023

Thanks @mtsokol. If there are any other fixups lets take care of it in a followup.

@ngoldbaum ngoldbaum merged commit 7e8bb12 into numpy:main Sep 18, 2023
@mtsokol mtsokol deleted the update-nep-52-file branch September 18, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rgommers rgommers rgommers left review comments

Assignees

@mtsokol mtsokol

Labels

04 - Documentation Numpy 2.0 API Changes

Projects

None yet

Milestone

2.0.0 release

Development

Successfully merging this pull request may close these issues.

3 participants

@mtsokol @rgommers @ngoldbaum