BLD: fix _umath_linalg dependencies
#24584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I've made a sub-PR, rgommers#58, that I think should resolve the test failures. |
Closes numpygh-24512, where `linalg.eigvalsh` was observed to be non-thread safe. This was due to the non-thread safe `lapack_lite` being called instead of the installed BLAS/LAPACK. Co-authored-by: Albert Steppi <[email protected]>
rgommers
force-pushed
the
fix-umath-linalg
branch
from
13c55db to
13d3ec8
Compare
rgommers
changed the title
_umath_linalg dependencies, remove linalg.lapack_lite_umath_linalg dependencies
Member
|
Thanks @steppi I incorporated your fix with a tweak. Reverting the removal of |
Member
|
Can you verify that this is still a complete fix? |
Contributor
Author
Looks good and works locally. Thanks @rgommers. |
Member
|
Thanks! Let's go with this then. Marked for backport, so it should be present in |
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Aug 30, 2023
Closes numpygh-24512, where `linalg.eigvalsh` was observed to be non-thread safe. This was due to the non-thread safe `lapack_lite` being called instead of the installed BLAS/LAPACK. Co-authored-by: Ralf Gommers <[email protected]>
charris
changed the title
_umath_linalg dependencies_umath_linalg dependencies
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Nov 11, 2023
Closes numpygh-24512, where `linalg.eigvalsh` was observed to be non-thread safe. This was due to the non-thread safe `lapack_lite` being called instead of the installed BLAS/LAPACK. Co-authored-by: Ralf Gommers <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24512, where
linalg.eigvalshwas observed to be non-thread safe. I determined that the issue was due to the non-thread safelapack_litebeing called instead of the installed BLAS/LAPACK that appears innp.__show__.config(). @rgommers found that the issue is due toblasandlapackbeing missing from the_umath_linalgextension's sources. He proposed the following fix and I've confirmed that it works locally.