BUG: fix NPY_cast_info error handling in choose #24484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerjereddy
approved these changes
Aug 21, 2023
Contributor
tylerjereddy
left a comment
tylerjereddy
left a comment
There was a problem hiding this comment.
Ah that makes sense, LGTM if CI passes.
Member
|
Thanks Nathan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24459.
cast_infoneeds to be declared before the firstgoto fail, otherwise thexfreein thefailblock receives uninitialized data.@tylerjereddy sorry I missed this when we were reviewing #24188, going to try to keep this pattern in mind when looking at code that uses the cast C API in the future.