TYP,DOC: Annotate and document the metadata parameter of the dtype constructor#23887
Merged
charris merged 2 commits intonumpy:mainfrom Jun 6, 2023
Merged
TYP,DOC: Annotate and document the metadata parameter of the dtype constructor#23887charris merged 2 commits intonumpy:mainfrom
metadata parameter of the dtype constructor#23887charris merged 2 commits intonumpy:mainfrom
Conversation
BvB93
added
04 - Documentation
09 - Backport-Candidate
Member
|
Thanks Bas. |
|
Amazing! 🎉 Under 4 hours from reporting to merge into main. Thanks! |
charris
changed the title
metadata parameter of the dtype constructormetadata parameter of the dtype constructor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23886
Adds annotations and documentation for the
metadataparameter of thedtypeconstructor. While there was previously documentation on thedtype.metadataattribute, there was no mention of it being an accepted parameter for the actual constructor itself (even though it's been there for ages).