Repository navigation
DOC: Try to clarify the NPY_TARGET_VERSION release note - #23872
Merged
Merged
Conversation
It seems that the release note should have at least been more clear about `oldest-support-numpy` not being necessary anymore.
pllim
reviewed
Jun 5, 2023
pllim
left a comment
pllim
left a comment
Contributor
There was a problem hiding this comment.
This LGTM but I'll ping @saimn who originally asked and also @astrofrog, our other release manager at astropy.
Thank you! 🙇♀️
Co-authored-by: P. L. Lim <[email protected]>
Contributor
|
Thanks, that's basically what I understood but the proposed changes make it clearer 👍 |
Member
|
Thanks Sebastian. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that the release note should have at least been more clear about
oldest-support-numpynot being necessary anymore.@pllim could you have a look and see if this seems clearer?