Skip to content

DOC: Added pathlib.Path where applicable#23822

Merged
charris merged 2 commits into
numpy:mainfrom
ganesh-k13:npyio_pathlib
May 27, 2023
Merged

DOC: Added pathlib.Path where applicable#23822
charris merged 2 commits into
numpy:mainfrom
ganesh-k13:npyio_pathlib

Conversation

@ganesh-k13

@ganesh-k13 ganesh-k13 commented May 27, 2023

Copy link
Copy Markdown
Member

Problem

Changes

  • Add pathlib.Path where support exists.

Future work:

The plan is to rewrite some parts that use os.path. This can be achieved more cleanly with pathlib.Path. Example

@eric-wieser

Copy link
Copy Markdown
Member

Are you sure that all of these functions actually work with pathlib.Path?

@ganesh-k13

Copy link
Copy Markdown
Member Author

I tried it manually, shall I add a test case to be sure? I don't think the support is platform dependent, but to be on the safe side.

@charris
charris merged commit 7669b86 into numpy:main May 27, 2023
@charris

charris commented May 27, 2023

Copy link
Copy Markdown
Member

Thanks @ganesh-k13 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants