Repository navigation
DOC: Improve description of the dtype parameter in np.array docstring - #22736
Merged
Merged
Conversation
seberg
approved these changes
Dec 5, 2022
seberg
left a comment
seberg
left a comment
Member
There was a problem hiding this comment.
Thanks! I think this is mch better. Maybe we have a cool idea later, will wait a bit in case someone has a great idea, but put it in tomorrow otherwise.
| (`dtype`, `order`, etc.). | ||
| only be made if ``__array__`` returns a copy, if obj is a nested | ||
| sequence, or if a copy is needed to satisfy any of the other | ||
| requirements (``dtype``, ``order``, etc.). |
Member
There was a problem hiding this comment.
Hah, we do use single ticks for arguments, but I think here both makes sense in either case :).
Member
|
OK, going to put it in since I think it is an improvement and we can easily follow up on it. Thanks again. (not bothering about a line being one character long) |
|
Awesome! Thanks for fixing the docs! 🥳 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10614
Once the dtype promotion rules are simplified, we can follow up with a more precise explanation.
cc @seberg