Skip to content

MAINT, CI: Update Ubuntu 18.04 to Ubuntu 20.04#22598

Merged
seberg merged 2 commits intonumpy:mainfrom
charris:update-to-focal
Nov 17, 2022
Merged

MAINT, CI: Update Ubuntu 18.04 to Ubuntu 20.04#22598
seberg merged 2 commits intonumpy:mainfrom
charris:update-to-focal

Conversation

@charris
Copy link
Copy Markdown
Member

@charris charris commented Nov 15, 2022 •
edited
Loading

Github actions will drop support for 18.04 April 1, 2023. There are now sporadic test cancelations due to warning brownouts, and the NumPy 1.24.x release will overlap that date, so increase the Ubuntu version.

The main change here is that there is no support for gcc-6 in Ubuntu 20.04, so testing with that version is dropped.

@charris charris added this to the 1.24.0 release milestone Nov 15, 2022
@charris
Copy link
Copy Markdown
Member Author

charris commented Nov 15, 2022

Hmm, build error running "full" on azure:

numpy/core/src/multiarray/einsum_sumprod.c.src:1264:1: internal compiler error: in coverage_begin_function, at coverage.c:656

@charris charris force-pushed the update-to-focal branch 2 times, most recently from be3882f to f870b36 Compare November 15, 2022 22:48
@charris
Copy link
Copy Markdown
Member Author

charris commented Nov 16, 2022

Coverage fails in Ubuntu 20.04, but works in 22.04. Unfortunately, there are a lot of error like this:

numpy/core/src/multiarray/nditer_constr.c:2004:32: error: writing 8 bytes into a region of size 0 [-Werror=stringop-overflow=]

See https://github.com/numpy/numpy/actions/runs/3474938876/jobs/5808717885 for more. The -Werror=stringop-overflow option seems to be new with that version (new in gcc-10), IIRC, we used to get warnings., In any case, we should probably fix those warnings. For now, I'm just going to disable the coverage option.

@charris
CI: Update to Ubuntu 18.04 to 20.04
6736c78 
Github actions will drop support for 18.04 April 1, 2023. There
are now sporadic test cancelations due to warning brownouts, and
the NumPy 1.24.x release will overlap that date, so increase the Ubuntu
version.

The main change here is that there is no support for gcc-6 in Ubuntu
20.04, so testing with that version is also dropped.
@seberg
Copy link
Copy Markdown
Member

seberg commented Nov 16, 2022

LGTM, but not merging since I am not sure if you want to take a shot at fix the coverage warnings this first.

Do we need to document that GCC 6 is not officially tested anymore?

@charris
Copy link
Copy Markdown
Member Author

charris commented Nov 16, 2022

fix the coverage warnings this first

Since that is fixed in Ubuntu 22.04, I'm not going to worry about it. The warnings in that version are unrelated and due to the stringop-overflow warning, so once that is taken care of we can re-enable the coverage. I don't think the lack of coverage testing is a blocker.

Do we need to document that GCC 6 is not officially tested anymore?

Good point. I'll add a release note, but not sure what section to put it in.

@seberg
Copy link
Copy Markdown
Member

seberg commented Nov 16, 2022

Maybe just "compatibility" if we are talking release notes? Seems OK, and we can still move it if desired.

@charris
DOC: Add compatibility release note.
c5e30a8 
We have dropped GCC-6 build testing.
@seberg
Copy link
Copy Markdown
Member

seberg commented Nov 17, 2022

OK, lets put this in, thanks Chuck. Was there something to followup on if the warning fixes work out?

@seberg seberg merged commit 5170119 into numpy:main Nov 17, 2022
@charris charris deleted the update-to-focal branch December 29, 2022 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

03 - Maintenance component: CI

Projects

None yet

Milestone

1.24.0 release

Development

Successfully merging this pull request may close these issues.

2 participants

@charris @seberg