DEP: Expire deprecation to ignore bad dtype= in logical ufuncs#22541
Merged
rossbar merged 3 commits intonumpy:mainfrom Nov 7, 2022
Merged
DEP: Expire deprecation to ignore bad dtype= in logical ufuncs#22541rossbar merged 3 commits intonumpy:mainfrom
rossbar merged 3 commits intonumpy:mainfrom
Conversation
Basically only `bool` and `object dtype make sense, but they did not work correctly. The dtype argument was rather ignored often.
charris
reviewed
Nov 7, 2022
Co-authored-by: Charles Harris <[email protected]>
rossbar
approved these changes
Nov 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically only
booland `object dtype make sense, but they did not work correctly. The dtype argument was rather ignored often.