BUG: Fix incorrect refcounting in new asarray path#22236
Conversation
The new path to preserve dtypes provided by creating a view got the reference counting wrong, because it also hit the incref path that was needed for returning the identity. This fixes up numpygh-21995 Closes numpygh-22233
|
(I did not add a test, mem-leak testing would have found it easily, we just don't run it regularly. And it is so massive, that everyone notices anyway :)) |
I removed the broken wheels uploaded in the last ~30 hours. For the record, this is how: |
|
One can also remove the wheels using the gui at https://anaconda.org/scipy-wheels-nightly/numpy/files if logged in and permitted. To run the wheel CI
|
|
Ah, thanks! I likely don't have rights to yank the wheels from anaconda, but there is no need for that anyway. However, triggering a new build should work for me probably. |
The new path to preserve dtypes provided by creating a view got the reference counting wrong, because it also hit the incref path that was needed for returning the identity.
This fixes up gh-21995
Closes gh-22233
@charris I keep forgetting how (should note it somewhere :)). Could you retrigger the nightlies, since this seems to affect downstream CI quite annoyingly.