Skip to content

Conversation

@charris
Copy link
Member

@charris charris commented Aug 11, 2022

Backport of #22105.

The lerp test compared the output of the original and the symmetric
functions by using basic assertion. Double precision errors could
accumulate in a way that the 2 outputs mismatch by epsilon.
For more information on the precision issue, see #22073

Fix: use assert_allclose instead for float comparison.

The lerp test compared the output of the original and the symmetric
functions by using basic assertion. Double precision errors could
accumulate in a way that the 2 outputs mismatch by epsilon.
For more information on the precision issue, see numpy#22073

Fix: use assert_allclose instead for float comparison.
@charris charris added 05 - Testing 08 - Backport Used to tag backport PRs labels Aug 11, 2022
@charris charris added this to the 1.23.2 release milestone Aug 11, 2022
@charris charris merged commit a5c9fb1 into numpy:maintenance/1.23.x Aug 11, 2022
@charris charris deleted the backport-22105 branch August 11, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

05 - Testing 08 - Backport Used to tag backport PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants