Skip to content

Conversation

@palbarta
Copy link
Contributor

The lerp test compared the output of the original and the symmetric
functions by using basic assertion. Double precision errors could
accumulate in a way that the 2 outputs mismatch by epsilon.
For more information on the precision issue, see #22073

Fix: use assert_allclose instead for float comparison.

The lerp test compared the output of the original and the symmetric
functions by using basic assertion. Double precision errors could
accumulate in a way that the 2 outputs mismatch by epsilon.
For more information on the precision issue, see numpy#22073

Fix: use assert_allclose instead for float comparison.
@mattip
Copy link
Member

mattip commented Aug 10, 2022

Thanks @palbarta

@mattip mattip merged commit 86a368f into numpy:main Aug 10, 2022
@mattip mattip added the 09 - Backport-Candidate PRs tagged should be backported label Aug 10, 2022
@palbarta palbarta deleted the lerp_symmetric_test_issue_22073 branch August 10, 2022 22:40
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Aug 11, 2022
@InessaPawson
Copy link
Member

Hi-five on merging your first pull request to NumPy, @palbarta! We hope you stick around! Your choices aren’t limited to programming – you can review pull requests, help us stay on top of new and old issues, develop educational material, work on our website, add or improve graphic design, create marketing materials, translate website content, write grant proposals, and help with other fundraising initiatives. For more info, check out: https://numpy.org/contribute
Also, consider joining our mailing list. This is a great way to connect with other cool people in our community and be part of important conversations that affect the development of NumPy: https://mail.python.org/mailman/listinfo/numpy-discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

4 participants