Skip to content

BLD: Try building python3.11 wheels. #22102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
charris merged 1 commit into from
Aug 12, 2022
Merged

BLD: Try building python3.11 wheels. #22102

charris merged 1 commit into from
Aug 12, 2022

Conversation

@charris
Copy link
Member

@charris charris commented Aug 9, 2022

Try simplest approach to building Python3.11 wheels. This will probably fail on windows and macosx.

@charris charris added the 36 - Build Build related PR label Aug 9, 2022
@mattip
Copy link
Member

mattip commented Aug 9, 2022

The cp311 wheel builds failed with

cibuildwheel: No build identifiers selected: BuildSelector(skip_config='cp36-* cp37-* pp37-* *-manylinux_i686 *_ppc64le *_s390x *-musllinux*', build_config='cp311-manylinux_x86_64', requires_python=None, prerelease_pythons=False)

I think everyone will need a new cibuildwheel that support 311. See pypa/cibuildwheel#1221

@charris
Copy link
Member Author

charris commented Aug 9, 2022

I think everyone will need a new cibuildwheel that support 311

Looks like it. Might be a couple of weeks.

@charris
Copy link
Member Author

charris commented Aug 11, 2022

close/reopen

@charris charris closed this Aug 11, 2022
@charris charris reopened this Aug 11, 2022
@lithomas1
Copy link
Collaborator

lithomas1 commented Aug 12, 2022

@charris maybe try bumping cibuildwheel to 2.9.0? Looks like py 3.11 should be supported since that release.

@charris charris force-pushed the add-python-311-wheels branch from 98d2fd0 to f7ea43f Compare August 12, 2022 15:08
@charris
Copy link
Member Author

charris commented Aug 12, 2022

maybe try bumping cibuildwheel to 2.9.0?

Thanks, let's give that a shot.

@neutrinoceros neutrinoceros mentioned this pull request Aug 12, 2022
Merged
@charris charris changed the title BLD, WIP: Try building python3.11 wheels. BLD: Try building python3.11 wheels. Aug 12, 2022
@charris
Copy link
Member Author

charris commented Aug 12, 2022

Looks good. I'm going to put this in.

@charris charris merged commit 4ee7b89 into numpy:main Aug 12, 2022
@charris charris deleted the add-python-311-wheels branch August 12, 2022 16:46
@charris charris added the 09 - Backport-Candidate PRs tagged should be backported label Aug 12, 2022
@charris charris added this to the 1.23.2 release milestone Aug 12, 2022
@charris
Copy link
Member Author

charris commented Aug 12, 2022

@mattip @matthew-brett Multibuild for aarch64 is not supporting Python 3.11, do we need to update something?

charris added a commit to charris/numpy that referenced this pull request Aug 12, 2022
@charris
BLD: Build python3.11.0rc1 wheels.
cb63445 
Backport of numpy#22102.
@charris charris mentioned this pull request Aug 12, 2022
Merged
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Aug 12, 2022
@charris charris removed this from the 1.23.2 release milestone Aug 12, 2022
@charris
Copy link
Member Author

charris commented Aug 13, 2022

@lithomas1 How does cibuildwheel get run on travis? I don't see it anywhere and it isn't uploading the python 3.11 wheel for aarch64.

@ZainRizvi ZainRizvi mentioned this pull request Jun 2, 2023
Closed
pytorchmergebot pushed a commit to pytorch/pytorch that referenced this pull request Jun 3, 2023
@ZainRizvi @pytorchmergebot
[BE] Fix lintrunner init on python 3.11 (#102889)
4254e05 
Makes the `lintrunner init` command work with python 3.11

The old version of numpy would fail to install on python 3.11, where setup would fail to build wheels with the error `AttributeError: fcompiler. Did you mean: 'compiler'?`

The latest version of numpy installs just fine however, so switching to that.

More details in numpy/numpy#22102
Pull Request resolved: #102889
Approved by: https://github.com/kit1980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

36 - Build Build related PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@charris @mattip @lithomas1