BUG: Avoid errors on NULL during deepcopy #22038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses concerns raised in the two linked issues by: Casting NULL objects to Py_None within _deepcopy_call to avoid issues within CPython's deepcopy Setting _deepcopy_call to return an int code for error/success, which is then checked in array_deepcopy Closes numpygh-8706, numpygh-21883
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #21996.
Closes #8706, #21883
Addresses concerns raised in the two linked issues by:
NULLobjects toPy_Nonewithin_deepcopy_callto avoid issues within CPython'sdeepcopy_deepcopy_callto return anintcode for error/success, which is then checked inarray_deepcopy