Skip to content

Conversation

@BvB93
Copy link
Member

@BvB93 BvB93 commented Jul 12, 2022

Closes #21972

There were two issues with the previous np.angle annotations:

  • It assumed that all array-likes would be reduced to scalars.
  • It did not take into account that complex dtypes would be coerced into their float-based equivalent.

@bmerry
Copy link
Contributor

bmerry commented Jul 12, 2022

Is there any way for the overloads to indicate that the precision is preserved (complexfloating[T, T] -> floating[T])?

@charris charris merged commit 0845fbf into numpy:main Jul 12, 2022
@charris
Copy link
Member

charris commented Jul 12, 2022

Thanks Bas.

@BvB93 BvB93 deleted the angle branch July 13, 2022 11:22
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Jul 24, 2022
@charris charris removed this from the 1.23.2 release milestone Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: incorrect type annotations for np.angle

3 participants