Move doctesting part of refguide-check into a separate cross-project tool#21962
Closed
ev-br wants to merge 7 commits intonumpy:mainfrom
Closed
Move doctesting part of refguide-check into a separate cross-project tool#21962ev-br wants to merge 7 commits intonumpy:mainfrom
ev-br wants to merge 7 commits intonumpy:mainfrom
Conversation
Missing commas in `masked_array(data=[1 2 3], ...)` confuse the checker.
$ python runtests.py --doctests -s core -v to run doctests in `numpy.core` etc
ev-br
changed the title
Member
|
It seems the parallel PR in scipy/scipy#16391 got more review. Linting here is failing, but the test itself seems to be passing (logs were removed but there is a green checkmark on the macOS build). I find the choice of tacking the doctests on to the macOS CI run in azure a strange one, but that is the way we have been doing it historically. It might make sense to add doctest runs to a linux and windows CI run. Is there any thought to the tasks at the beginning of the PR, in particular the location/name of the script? In any case we should pin to a known tag/version of the script. |
Member
Contributor
Author
|
Yup, indeed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #21070, here is a proof-of-concept implementation of the doctesting part of refguide-check, with the main implementation common to numpy and scipy (and whoever else wants to take it for a ride).
The matching scipy PR, scipy/scipy#16391, runs with warnings turned to errors, while this one is not.
I'm not sure if I activated the CI correctly, but anyway, locally it's plumbed through runtests.py, so
does the trick (after
$ python -mpip install git+https://github.com/ev-br/scpdt.git).Several things here are still WIP:
doctestsor something else?Modulo these, the main thing is there and ready for a spin :-).