Skip to content

Revert "ENH: Adding __array_ufunc__ capability to MaskedArrays" #21960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mattip merged 1 commit into from
Jul 9, 2022
Merged

Revert "ENH: Adding __array_ufunc__ capability to MaskedArrays" #21960

mattip merged 1 commit into from
Jul 9, 2022

Conversation

@mattip
Copy link
Member

@mattip mattip commented Jul 9, 2022

Reverts #16022 since it fails refguide check.

@mattip mattip mentioned this pull request Jul 9, 2022
Merged
@mattip
Copy link
Member Author

mattip commented Jul 9, 2022

I did not notice that PR #16022 broke mask comptability for np.ma.average(x, axis=1, keepdims=True) where x = np.ma.arange(6.).reshape(3, 2). Previously the result had mask = False, now it has mask = [False, False, False].

@mattip mattip merged commit 1ba5158 into main Jul 9, 2022
@charris charris deleted the revert-16022-masked_ufunc branch November 12, 2022 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mattip