ENH: Implement `f2py2e` with `argparse` #21923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

NamamiShanker wants to merge 115 commits into numpy:main from NamamiShanker:f2py_front

Contributor

NamamiShanker commented Jul 5, 2022 •

edited

Loading

This draft PR implements the F2PY frontend with argparse library. The aim is to split up one big f2py2e.py into 2 files. One file f2pyarg.py is responsible for parsing arguments file while other service.py deals with f2py core functionalities.

Some upcoming goals are:

Implement run_main(). It is the function responsible for generating wrappers and .pyf files.
Implement run_compile() responsible for compiling and building shared libraries.
Decide and implement deprecation of flags. For ex. - --f2py-wrapper-output, --skip-empty-wrappers
Code cleanup. Will involve refactoring and deciding which flags belong to which subparser.

github-actions bot added the 01 - Enhancement label

Member

charris commented Jul 5, 2022

I haven't read through this yet, but I approve of the goal. Having the front end use a modern standard should make f2py more maintainable. Next up, the templating :)

HaoZeke requested review from HaoZeke, melissawm and pearu

July 5, 2022 14:17

HaoZeke added the component: numpy.f2py label

BvB93 reviewed

View reviewed changes

numpy/f2py/service.py Outdated Show resolved Hide resolved

NamamiShanker force-pushed the f2py_front branch from b1e103e to f388c96 Compare

July 13, 2022 13:41

HaoZeke reviewed

View reviewed changes

numpy/f2py/__init__.py Outdated Show resolved Hide resolved

HaoZeke reviewed

View reviewed changes

numpy/f2py/__init__.py Outdated Show resolved Hide resolved

HaoZeke reviewed

View reviewed changes

numpy/f2py/capi_maps.py Outdated Show resolved Hide resolved

HaoZeke reviewed

View reviewed changes

numpy/f2py/diagnose.py Outdated Show resolved Hide resolved

HaoZeke reviewed

View reviewed changes

Member

HaoZeke left a comment

This is fantastic work, some minor comments aside. Also could you add a release note?

HaoZeke reviewed

View reviewed changes

numpy/f2py/service.py Outdated Show resolved Hide resolved

HaoZeke reviewed

View reviewed changes

numpy/f2py/service.py Outdated Show resolved Hide resolved

HaoZeke reviewed

View reviewed changes

numpy/f2py/service.py Outdated Show resolved Hide resolved

HaoZeke reviewed

View reviewed changes

numpy/f2py/utils.py Outdated Show resolved Hide resolved

HaoZeke reviewed

View reviewed changes

numpy/f2py/utils.py Outdated Show resolved Hide resolved

pearu requested changes

View reviewed changes

Contributor

pearu left a comment

I did a quick review and have couple of nits.

I did not review f2pyarg.py nor service.py because it is hard to tell what is new code there and what is the result of splitting existing code into different files. Could you mark the new code in these files somehow to ease reviewing?

numpy/f2py/diagnose.py Outdated Show resolved Hide resolved

numpy/f2py/diagnose.py Outdated Show resolved Hide resolved

numpy/f2py/utils.py Outdated Show resolved Hide resolved

numpy/f2py/utils.py Outdated Show resolved Hide resolved

numpy/f2py/utils.py Outdated Show resolved Hide resolved

numpy/f2py/f2pyarg.py Outdated Show resolved Hide resolved

numpy/f2py/utils.py Outdated Show resolved Hide resolved

NamamiShanker force-pushed the f2py_front branch from 2836f58 to 5a44c5d Compare

July 24, 2022 12:16

Contributor Author

NamamiShanker commented Jul 24, 2022

I did a quick review and have couple of nits.

@pearu I have made the suggested changes, please have a look.

I did not review f2pyarg.py nor service.py because it is hard to tell what is new code there and what is the result of splitting existing code into different files. Could you mark the new code in these files somehow to ease reviewing?

I'll add comments explaining the changes in the frontend files.

Contributor Author

NamamiShanker commented Jul 24, 2022

I have added comments explaining step by step how the new frontend works @pearu. Please have a look and let me know any improvements or if you want further explanation.

Member

HaoZeke commented Jul 27, 2022

@NamamiShanker for the release notes, please create a file numpy/doc/release/upcoming_changes/21923.new_feature.rst and document it according to the numpy/doc/release/upcoming_changes/{README,template}.rst files :)

HaoZeke marked this pull request as ready for review

August 19, 2022 11:26

NamamiShanker mentioned this pull request

ENH: Meson build system support for F2PY's f2py -c command #22225

Closed

HaoZeke mentioned this pull request

ENH: distutils - add add options for "skip:" and "only:" to be passed to f2py #22508

Closed

HaoZeke mentioned this pull request

ENH: argparse f2py #20056

Closed

HaoZeke added 3 commits

August 24, 2023 20:59


          ENH: Start refactoring f2py front-end

e8ff86e


          ENH: Start using logging

1c6867e


          ENH: Add more options for the new front-end

60740fd

NamamiShanker added 26 commits

August 24, 2023 21:00


          FIX: Return full path string

0d7da60


          FIX: Print name of PosiPath type variable

83f84ce


          MAINT: Refactorings from code review

4e1fcd4


          MAINT: Refactorings from code review

523d41f


          FIX: Typing errors

99d59db


          FIX: Replace builtin types with typing

b181708

python 3.8 does not support substriptable builtin types.


          MAINT: Add docstring to explain open_build_dir

0a18b55


          ENH: Add temporary comments

b489d88


          ENH: Use builtin types in place of typing

3c69667


          BUG: Seperate paths by colon

9323b91


          MAINT: Sort by alphabetical order

3b04931


          MAINT: Fix typo

8a23d37


          ENH: Add custom string flags parsing

e528972


          FIX: Flag nargs

df65a2e


          MAINT: Correct docstring

e0637df


          BUG: "--noopt" flag bugfix

c81e90b


          MAINT: Return Path object of tempdir

3ac23f8


          BUG: Lower C wrapper defs by default for less buggy imports

0b2c031


          BUG: Read module name from pyf file without -c

c910d6b


          Revert "BUG: Read module name from pyf file without -c"

a35027e

This reverts commit 31ec066.


          BUG: Change default value of lower flag

263e3f9


          BUG: Change default module name

9ef6974


          MAINT: Set Default empty gen False

9e8756c


          BUG: Get module name from postlist

78b9b98


          BUG: Shift files to the end of sys.argv

8ce9426


          BUG: f2pyarg sort args fix

5aa96cd

HaoZeke force-pushed the f2py_front branch from 3977d50 to 5aa96cd Compare

August 24, 2023 21:01

HaoZeke mentioned this pull request

RFC: On updates to the f2py CLI #24552

Closed

HaoZeke mentioned this pull request

DOC: f2py CLI documentation enhancements #25124

Merged

HaoZeke mentioned this pull request

ENH: Release crackfortran as a standalone tool for parsing Fortran. #25307

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

01 - Enhancement component: numpy.f2py