MAINT: Adapt npt._GenericAlias to Python 3.11 types.GenericAlias changes - #21605

Note that types.GenericAlias still seems to updated on a regular basis in the current 3.11 dev cycle (so more changes may or may not be necessary in the future)

There's a very high bar for changes after beta1, and I don't think anything of relevance will change anymore, unless discovered to be really badly broken.

There's a very high bar for changes after beta1, and I don't think anything of relevance will change anymore, unless discovered to be really badly broken.

Then let's hope python/cpython#92335 will remain the last of it, as it just introduced a new types.GenericAlias attribute for 3.11b3.

What's going on with the armv7_simd_test CI run? Does it have a separate requirements file?

_____________ ERROR collecting typing/tests/test_generic_alias.py ______________
ImportError while importing test module '/usr/local/lib/python3.8/dist-packages/numpy-1.24.0.dev0+51.g91819691c-py3.8-linux-armv7l.egg/numpy/typing/tests/test_generic_alias.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/lib/python3.8/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
/usr/local/lib/python3.8/dist-packages/numpy-1.24.0.dev0+51.g91819691c-py3.8-linux-armv7l.egg/numpy/typing/tests/test_generic_alias.py:13: in <module>
    from typing_extensions import Unpack
E   ModuleNotFoundError: No module named 'typing_extensions'

Then let's hope python/cpython#92335 will remain the last of it, as it just introduced a new types.GenericAlias attribute for 3.11b3.

Good point. The respective PR for 3.11 is not even merged yet though.

What's going on with the armv7_simd_test CI run? Does it have a separate requirements file?

I couldn't find typing_extensions explicitly in a requirements file. Is it pulled in via some other dependency?

I couldn't find typing_extensions explicitly in a requirements file. Is it pulled in via some other dependency?

It's just been added in this PR via 4682699.

What's going on with the armv7_simd_test

Don't know, the error is new. I was going to rerun it. The test sets up its own docker run.

I think there should be a call to && python3 -m pip install test_requirements.txt inserted into the docker command here

I think there should be a call to && python3 -m pip install test_requirements.txt inserted into the docker command here

numpy/.github/workflows/build_test.yml

Lines 283 to 285 in d75e7d8

	docker run --rm --interactive -v $(pwd):/numpy the_build /bin/bash -c "
	cd /numpy && python3 runtests.py -n -v -- -k test_simd
	"

Let me give it a shot.

Does this need a backport? We will be supporting Python 3.11 in NumPy 1.23 after the first Python rc.

Does this need a backport? We will be supporting Python 3.11 in NumPy 1.23 after the first Python rc.

Good point, yes. Though maybe we should a bit until #21308 is merged with all the remaining py3.11 changes?

Though maybe we should a bit until #21308 is merged

OK, I marked both that PR and this for 1.23.1, there is no rush for 3.11.

Well, the last CI job is still spitting out HTTP errors when installing openblas, but besides that everything is finally green.

LGTM. I reran the macOS job and it passed. Thanks @BvB93