Skip to content

TEST: on PyPy, skip hanging slow test [wheel build] - #21425

Merged
seberg merged 2 commits into
numpy:mainfrom
mattip:skip-pypy
May 4, 2022
Merged

TEST: on PyPy, skip hanging slow test [wheel build]#21425
seberg merged 2 commits into
numpy:mainfrom
mattip:skip-pypy

Conversation

@mattip

@mattip mattip commented May 2, 2022

Copy link
Copy Markdown
Member

I noticed that recent wheel builds have failed for PyPy, this test, marked slow is hanging. Skip it unconditionally on PyPy.

@mattip mattip mentioned this pull request May 2, 2022
Closed
@seberg

seberg commented May 2, 2022

Copy link
Copy Markdown
Member

Hmmm, the failure is a segfault here:

2022-05-02T09:22:09.6210548Z Users/runneradmin/AppData/Local/Temp/cibw-run-ugil7s2m/pp38-win_amd64/venv-test/lib/site-packages/numpy/lib/tests/test_function_base.py::TestVectorize::test_scalar PASSED [ 59%]
2022-05-02T09:22:18.2809298Z Users/runneradmin/AppData/Local/Temp/cibw-run-ugil7s2m/pp38-win_amd64/venv-test/lib/site-packages/numpy/lib/tests/test_function_base.py::TestVectorize::test_large 
D:\a\numpy\numpy/tools/wheels/cibw_test_command.sh: line 14:   202 Segmentation fault

which seems rather surprising?

@seberg

seberg commented May 2, 2022

Copy link
Copy Markdown
Member

Heh, new failure is:

2022-05-02T11:28:10.3600672Z tmpdir = local('C:\\Users\\runneradmin\\AppData\\Local\\Temp\\pytest-of-runneradmin\\pytest-0\\test_large_archive0')
2022-05-02T11:28:10.3601267Z 
2022-05-02T11:28:10.3601974Z     @pytest.mark.skipif(np.dtype(np.intp).itemsize < 8,
2022-05-02T11:28:10.3602348Z                         reason="test requires 64-bit system")
2022-05-02T11:28:10.3602640Z     @pytest.mark.slow

in tets_format.py. Seems like it needs something like a @requires_memory(free_bytes=2 * 2*2**30).
Or alternatively, define a_shape = a.shape and then delete the original a there.

@charris

charris commented May 2, 2022

Copy link
Copy Markdown
Member

See also #21405.

seberg
seberg reviewed May 2, 2022
View reviewed changes
Comment thread numpy/lib/tests/test_format.py
with open(fname, "wb") as f:
np.savez(f, arr=a)

del a

@seberg seberg May 2, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty to add this, but I am not quite sure that PyPy will clean up quickly enough on a del here? So on PyPy, should we use 2 * (2 * 2**30) bytes for the requires_memory?

@seberg

seberg commented May 4, 2022

Copy link
Copy Markdown
Member

I am not sure this is the final word. But these are just tests and it seems to get the wheel build going, so I am going to merge for now. Thanks Matti.

@seberg
seberg merged commit c62930f into numpy:main May 4, 2022
@seberg seberg mentioned this pull request May 6, 2022
Closed
@mattip
mattip deleted the skip-pypy branch December 27, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seberg seberg seberg left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mattip @seberg @charris