BUG: fix compilation error for VS 141 and earlier#21366
Merged
charris merged 1 commit intonumpy:mainfrom Apr 21, 2022
Merged
Conversation
Member
Author
|
The CI runs VS 2019 and will not test the other I had to |
Member
|
The test failure looks similar to the previous failures of the cygwin and simd runs, the error message is not informative. I'll try fixing it later. @serge-sans-paille Does this look right to you. |
Contributor
Member
|
Close/reopen |
charris
reviewed
Apr 21, 2022
| if (arrsize > 1) { | ||
| qsort_<vector<npy_int>, npy_int>((npy_int *)arr, 0, arrsize - 1, | ||
| 2 * log2(arrsize)); | ||
| 2 * (npy_int)log2(arrsize)); |
Member
There was a problem hiding this comment.
Hmm. I don't know if this even matters much, but could do (npy_int)(2 * log2(arrsize)));
Member
|
Let's give this a shot. I do worry about the complexity of this implementation of quicksort, but that is a bigger problem. Thanks Matti. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compilers before vs 1922 are missing the
_knot_mask16intrinsic, use a simpleNOTinstead.Also clean up a few stray
npy_intp/npy_intwarnings.Fixes #21346
I verified the compiler version using https://godbolt.org/z/KMYhzaM1e.