MAINT: Add compile flag to disable voltbl on MSVC 142#21360
Merged
mattip merged 1 commit intonumpy:mainfrom Apr 21, 2022
Merged
MAINT: Add compile flag to disable voltbl on MSVC 142#21360mattip merged 1 commit intonumpy:mainfrom
mattip merged 1 commit intonumpy:mainfrom
Conversation
Add flag to disable the voltab section in the generated library, which (if present) appears to break mingw-w64 linking. See: ocaml/ocaml@0ac7358 and matthew-brett/dll_investigation#1 (comment)
matthew-brett
force-pushed
the
no-msvc-voltab
branch
from
aa0d322 to
422701d
Compare
matthew-brett
referenced
this pull request
Apr 19, 2022
This should disable the voltab section in the generated DLL, which appears to break mingw-w64 linking. See: ocaml/ocaml@0ac7358
Member
|
xref #20880. This buys us a little breathing room and could allow using the current vs2019 toolchain for wheels. |
Member
|
The comment on the ocaml commit says
I think the risk is acceptable. |
Contributor
Author
|
Right - the risk is only that we continue to get the same emulation performance - for this library specifically - as we would for a VS2017 build. And I suppose there is some hope we will build ARM64 wheels, at some point. |
Contributor
Author
|
Also xref current issue building with VS2017 - #21346 |
2 tasks
charris
changed the title
Member
|
Thanks @matthew-brett |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add flag to disable the voltab section in the generated library, which
(if present) appears to break mingw-w64 linking.
See:
ocaml/ocaml@0ac7358
and
matthew-brett/dll_investigation#1 (comment)