Skip to content

DOC: Update arctan2 docstring based on doctest output#21064

Merged
rossbar merged 1 commit intonumpy:mainfrom
pllim:patch-1
Feb 16, 2022
Merged

DOC: Update arctan2 docstring based on doctest output#21064
rossbar merged 1 commit intonumpy:mainfrom
pllim:patch-1

Conversation

@pllim
Copy link
Contributor

@pllim pllim commented Feb 15, 2022

As per astropy/astropy#12853 (comment) . cc @mhvk and @lpsinger

p.s. We really shouldn't be picking up your doctest but since we are right now, might as well fix it?

xref scientific-python/pytest-doctestplus#174

Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix LGTM, thanks @pllim . The alarming thing is that this isn't failing in numpy's tests, which indicates that we may need to take a closer look at how/whether doctest is properly picking up all the ufunc docstrings.

That's a separate issue though, thanks for the fix!

@rossbar rossbar merged commit 5a53fa9 into numpy:main Feb 16, 2022
@pllim pllim deleted the patch-1 branch February 16, 2022 03:30
@charris charris changed the title arctan2: Update docstring based on doctest output DOC: Update arctan2 docstring based on doctest output Feb 16, 2022
@InessaPawson
Copy link
Member

Hi-five on merging your first pull request to NumPy, @pllim! We hope you stick around! Your choices aren’t limited to programming – you can review pull requests, help us stay on top of new and old issues, develop educational material, work on our website, add or improve graphic design, create marketing materials, translate website content, write grant proposals, and help with other fundraising initiatives. For more info, check out: https://numpy.org/contribute
Also, consider joining our mailing list. This is a great way to connect with other cool people in our community and be part of important conversations that affect the development of NumPy: https://mail.python.org/mailman/listinfo/numpy-discussion

lithomas1 pushed a commit to lithomas1/numpy that referenced this pull request Mar 6, 2022
melissawm pushed a commit to melissawm/numpy that referenced this pull request Apr 12, 2022
seberg pushed a commit to seberg/numpy that referenced this pull request Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants