MAINT: Relax asserts to match relaxed reducelike resolution behaviour#20754
Merged
charris merged 1 commit intonumpy:mainfrom Jan 6, 2022
Merged
MAINT: Relax asserts to match relaxed reducelike resolution behaviour#20754charris merged 1 commit intonumpy:mainfrom
charris merged 1 commit intonumpy:mainfrom
Conversation
mhvk
approved these changes
Jan 6, 2022
Contributor
mhvk
left a comment
mhvk
left a comment
There was a problem hiding this comment.
Very strange indeed that this didn't cause problems during regular CI. Is there no debug run normally?
Anyway, looks good!
Contributor
|
p.s. Obviously should wait for tests to finish -- do they include the test that failed after merging #20729? If not, then perhaps this PR should also adjust the CI matrix... |
Member
Author
|
The test that failed was the newly added one, so it should be run (and I checked the debug run locally this time). I just checked, the debug runs had failed the first time as well, but probably because of a failed lint because of a 80 character line limit, we missed that... |
Contributor
|
OK, great that we now know why we missed it... |
This closes numpygh-20751, which was due to the assert not being noticed triggered (not sure why) during initial CI run. The behaviour is relaxed, so the assert must also be relaxed.
seberg
force-pushed
the
fixup-relax-dtype-identity
branch
from
b170cbc to
ca976a1
Compare
Member
Author
|
(just fixed up the comment slightly) |
Member
|
Thanks Sebastian. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes gh-20751, which was due to the assert not being noticed
triggered (not sure why) during initial CI run.
The behaviour is relaxed, so the assert must also be relaxed.