Skip to content

BUG: Fix array dimensions solver for multidimensional arguments in f2py#20721

Merged
pearu merged 3 commits intonumpy:mainfrom
pearu:gh20709
Jan 4, 2022
Merged

BUG: Fix array dimensions solver for multidimensional arguments in f2py#20721
pearu merged 3 commits intonumpy:mainfrom
pearu:gh20709

Conversation

@pearu
Copy link
Contributor

@pearu pearu commented Jan 3, 2022

Fixes #20709

@pearu pearu self-assigned this Jan 3, 2022
@pearu pearu requested a review from HaoZeke January 3, 2022 22:24
@pearu pearu added 06 - Regression 09 - Backport-Candidate PRs tagged should be backported labels Jan 3, 2022
Copy link
Member

@HaoZeke HaoZeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pearu pearu requested a review from HaoZeke January 3, 2022 22:44
@pearu
Copy link
Contributor Author

pearu commented Jan 3, 2022

@HaoZeke , I have now added a test that reproduces the issue. Sorry for the early review request. The PR should be ready for final review now.

Copy link
Member

@HaoZeke HaoZeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test, seems good to go once the tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: [Regression 1.21.4 -> 1.22.0] f2py infers integers incorrectly from shape (-(nterms):nterms,nvcount)

3 participants